-
Posted in : Read WP
-
I initially spotted this problem when installing “wpDiscuz”, a simple commenting plugin, because the styling of this theme’s comments is just bland and uninteresting, which is too bad because the theme itself is great.
(Pst: improve the comments styling, people will love you for it.)
And so I documented it on the WordPress plugin’s forum, believing it was an issue with the plugin:
https://wordpress.org/support/topic/manage-subscriptions-radio-items-invisible?replies=5However, I’ve been explained that it’s the theme that wraps the items in a block that overrides the style, making them invisible. Since this changes default behavior, it potentially breaks a lot of plugins (any that try to modify those blocks in a similar way without forcing their own style (CSS’s !important)).
I’m certain this is just a very small problem and is something you can find (perhaps not fix) in a couple of minutes, so pointing me in the right direction would already be appreciated.
Hi, can you provide your related page url to check whats wrong?
http://blog.sebastienvercammen.be/every-adventure-needs-a-start/
Go to the comment section and start typing. Click “Manage subscriptions”.
It’s the checkboxes – I had to overwrite their CSS with “!important” to make them visible.But all this is detailed in the wordpress support topic, so it’s not like it would’ve taken you long to figure it out…
Hi again, i just checked your site and it looks like you have fixed the issue with custom css, it seems to be working fine, do you need any extra help about this?
I will try to make this very simple.
I will use very short sentences. I will also ask my 12-year old niece to read this.
If she understands it (non-technical), I will post it.1. There is an issue.
2. I’ve said multiple times that I “fixed” it by overwriting CSS. I’ve said this on the public WordPress support forum, on your forum AND via mail to you personally.
3. I also said overwriting CSS with “!important” is NOT a fix.So, in short: the issue still exists.
If anyone uses your theme and uses similar forms, they WILL run into the same issue.Yes, you still need to fix it.
Yes, you should probably open your code.So please fix it.
Or, as I’ve said before, at least go through the effort of opening that single code file and pointing me in the wrong direction so I can put a real developer on this issue to solve it.you say “i fixed it” and then say “fix it” to me? Can you explain why “overwriting CSS with “!important” is NOT a fix” ?
you say “i fixed it” and then say “fix it” to me? Can you explain why “overwriting CSS with “!important” is NOT a fix” ?
Because hiding your shot wound with a big band-aid isn’t going to make it better.
In other words: you don’t fix a problem by smashing it some more until it fits. You fix it by using the proper shape in the first place.
Similar to how this thing works, you might’ve seen it before.
http://www.thejobpyramid.com/wp-content/uploads/2010/09/wooden_toy_shape_sorter_block_box.jpgusing custom css to fix a plugin compatibility issue is not a bad idea, there are milions of plugins out there and i can’t change the codes of the theme each time a user come across an issue (that can easily be fixed with a custom css) with a plugin.
The issue exists BECAUSE of the theme. It wrongly changes the structure of an existing component, so any plugin that uses/touches these (or any other form element with similar CSS) will not work correctly.
You’re basically saying you’re too lazy to look into it (and avoid any similar issue for all of your future clients) because it can be “fixed” with custom CSS?
Hi again, this theme sold over 2300+ times, and you are the only one reporting an issue about the forms with a plugin, I can deactivate uniform plugin with a future update but this time most of the users will complain about losing the fancy form elements. It is not about being lazy, because it doesn’t make sense to me.
You don’t even need to deactivate the uniform plugin..
Just makes sure it either:
1. Doesn’t overwrite more specific CSS
2. Doesn’t hide WordPress blocks for no reason
3. Doesn’t unnecessarily wrap form elements into another wrapper, which it then hidesactually this is how uniform works, it works by wrapping form elements, it is not something that can be altered about the plugin.
It can wrap elements, but it shouldn’t unnecessarily hide them with “display: none”.
maybe it shouldn’t but it is not an option within the plugin, it works that way,
Then un-break your theme.
You must be logged in and have valid license to reply to this topic.