Forum Replies Created
list of topics you have created till now.
-
-
hey, @tobetwobees2b
I have recently switched to a different theme, but I was eventually able to get the errors to resolve in G.S.C. I can’t remember exactly how I did it, but take a look at my child theme’s functions.php, the solution should be in there. Hope it helps!
https://github.com/collinbarrett/collinmbarrett/blob/master/functions.php
and it seems conversion of fontello to woff2 is not really possible. i tried converting through font squirrel, but the rendered symbols were cryptic/incorrect. guess I’ll stick with woff. i’m just a performance junkie.
continued thanks for the great theme!
Oh, disregard.
I had deregistered the provided fontello.css in my child theme’s functions.php, but either my fastcgi or redis cache hadn’t been purged. Now, since fontello.css is not loading, modernizr is not calling the original .woff file either.
Thanks.
ok, thanks for the html5 update, i am still getting up to snuff on that.
I also noticed that h1 is used for page titles as well as blog post titles on the blog pages. This throws validation warnings as screen readers would flag these as being the same level when really the page title should be h1 and the blog post title (on the blog page) should probably be an h2. On single post pages, though, the blog title should be h1 as it currently is. Fixing this would probably require a fair amount of CSS refactoring, though.
Thanks for the prompt response as always. I understand the role issue, and it’s just a warning, so that’s understandable and probably correct.
The ul issue, I think, is because I tried to fix an invalidation issue with the numbered blog pages. See issue 3 here: https://validator.w3.org/nu/?doc=https%3A%2F%2Fcollinmbarrett.com%2Fblog I tried to fix it just by removing rel=”last”, but that spawned a visual error on my site as well as I think those other ul issues I had reported, so I rolled that attempted fix back (https://github.com/collinbarrett/collinmbarrett/commit/5ad37b1c2b8138e2a266e8a25c2951d66794d396) and no longer see the ul errors. Sorry for the false report on that. Is there a way to fix that rel=”last” invalidation error (issue 3 in my example link above) when using numbered blog pages as opposed to just next/previous?
Many of the issues I was seeing were finicky issues with shortcode implementation. By trial/error, though, I found the best way to use shortcodes in a way that would not add an extra invalid p tag at the end of the generated divs for things like “accordion” and “event”.
There are a few role-related HTML5 warnings that some may or may not choose to fix. I prefer everything to be up to modern standards, so I fixed them in my child theme. https://github.com/collinbarrett/collinmbarrett
One major issue that I hope the developers will fix in a future update is that in blog-regular_sidebar.php (and likely other blog types) as well as post_other-feat_img_no_sidebar.php (and likely other post types), the ul for pagination is rendered way too soon up in the head. HTML5 assumes elements that should be in the body automatically open the body tag. Therefore, the rendered close head and open body tags by the theme are ignored and invalidated since body is automatically opened way up above when the ul for pagination is created. It’d be great if this is fixed, but this is beyond the scope of what I want to monkey around with in a child theme. This causes lots of other invalidation errors as links to stylesheets, etc. are seen by the browser as being in the body when they should be and were intended to be in the head.
Overall, though, this theme does seem to be very well coded except for that one big issue. Thanks.
bump
I’m also happy to add a member of your team to my Google Search Console as a restricted user temporarily, which will give you live access to what Google is seeing as far as Structured Data errors. This is an issue that should probably be fixed for SEO and probably affects all users. I’m not sure why the Structured Data Testing Tool is showing “All Good” when the Search Console flags these errors.
Thanks!
The code got omitted, but this is the line I am trying to add without the php tag wrappers based on that article. “if(function_exists(‘get_hatom_data’)) echo get_hatom_data();”
Here is a screenshot of the errors.
https://drive.google.com/file/d/0B8_RAAC1wiDrZHpMUF9iR2dnUk0/view?usp=sharing
So, I am still seeing these errors in Google Search Console. I used the guide linked below to fix the errors on all of the single posts by adding the code to functions.php in my child theme. Those errors are now gone in Google Search Console. I tried making a copy of template-archives.php and adding the code suggested in where I thought it should go, but a week later errors are still being freshly added in Google Search Console for single pages and archive pages. Since your theme doesn’t have the standard archive.php file, can you tell me based on this article which file(s) and where in that file(s) I should add
? Thanks.http://www.functionsphp.com/fix-google-structured-data-hentry-errors/
Ok, thanks. I just commented the font-size bit out in the parent theme and made a note to remember to do that whenever you push an update. I wish there was a child theme patch for this, but that’s fine. Now my tag cloud has varying sizes.
Hmm, ok, I am not getting any errors with that tool either. I am seeing them in Search Console, though, see below. Thanks for looking into it. It’s not a huge issue.
https://drive.google.com/file/d/0B8_RAAC1wiDrbDlkR21iWGVDYVU/view?usp=sharing
That custom css worked! Thanks!
Oh, sorry. Yes, it is:
collinmbarrett.com
Thanks for your prompt response!
Side note: email notifications from PixelWars consistently go to my Gmail spam folder. I always mark them as not spam, but it might be something to look into.
Hmm, ok, thanks for the prompt response. I might just wait to see if Firefox fixes it.
Ok, that’s what I was thinking. Thanks for the prompt response!
That worked. Thanks!
Adding the custom css worked for me to remove the share button, however can you tell me what code I need to remove to prevent the call to “sharebutton.co” altogether. I am optimizing for performance, and I don’t want that extra DNS lookup and http requests for something that is hidden. Thanks.
